<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi Balz<br>
<br>
I have refactored your pull request:<br>
<br>
- made Expires configurable, for example<br>
<br>
<yanel:resource-config
xmlns:yanel=<a class="moz-txt-link-rfc2396E" href="http://www.wyona.org/yanel/rti/1.0">"http://www.wyona.org/yanel/rti/1.0"</a>><br>
<yanel:rti name="file"
namespace=<a class="moz-txt-link-rfc2396E" href="http://www.wyona.org/yanel/resource/1.0">"http://www.wyona.org/yanel/resource/1.0"</a>/><br>
<br>
<yanel:property name="days-to-expiration" value="7"/><br>
</yanel:resource-config><br>
<br>
<br>
- I have removed your code re last modified, because this resource
implements ModifiableV2, such that YanelServlet will check on the
last modified and it does not need to be implemented by the
resource itself.<br>
<br>
Please give it a try and thanks again for your patch<br>
<br>
Thanks<br>
<br>
Michael<br>
<br>
<br>
Am 26.05.16 um 10:20 schrieb basZero:<br>
</div>
<blockquote
cite="mid:CAOXzDSFY7rrAMvR0vJEmmk7EZbfLwNGjYHOyUcDvY3r_s8BuBw@mail.gmail.com"
type="cite">
<div dir="ltr">
<p
style="margin-bottom:16px;color:rgb(51,51,51);font-family:'Helvetica
Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple
Color Emoji','Segoe UI Emoji','Segoe UI
Symbol';font-size:14px;line-height:22.4px;margin-top:0px!important">Hi,</p>
<p
style="margin-bottom:16px;color:rgb(51,51,51);font-family:'Helvetica
Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple
Color Emoji','Segoe UI Emoji','Segoe UI
Symbol';font-size:14px;line-height:22.4px;margin-top:0px!important">I
submitted another pull request:</p>
<p style="margin-bottom:16px;margin-top:0px!important"><font
face="Helvetica Neue, Helvetica, Segoe UI, Arial, freesans,
sans-serif, Apple Color Emoji, Segoe UI Emoji, Segoe UI
Symbol" color="#333333"><span
style="font-size:14px;line-height:22.4px"><a
moz-do-not-send="true"
href="https://github.com/wyona/yanel/pull/80/files"><a class="moz-txt-link-freetext" href="https://github.com/wyona/yanel/pull/80/files">https://github.com/wyona/yanel/pull/80/files</a></a></span></font><br>
</p>
<p
style="margin-bottom:16px;color:rgb(51,51,51);font-family:'Helvetica
Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple
Color Emoji','Segoe UI Emoji','Segoe UI
Symbol';font-size:14px;line-height:22.4px;margin-top:0px!important"><span
style="line-height:22.4px">For a framework like Yanel I
think it is crucial to fully support todays recommendations
stated by Google as most probably all web applications in
the internet are heavily depending on the SEO ranking at
Google.</span><br>
</p>
<p
style="margin-top:0px;margin-bottom:16px;color:rgb(51,51,51);font-family:'Helvetica
Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple
Color Emoji','Segoe UI Emoji','Segoe UI
Symbol';font-size:14px;line-height:22.4px">So this pull
request implements the requirements for browser caching:</p>
<ul
style="padding-left:2em;margin-top:0px;margin-bottom:16px;color:rgb(51,51,51);font-family:'Helvetica
Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple
Color Emoji','Segoe UI Emoji','Segoe UI
Symbol';font-size:14px;line-height:22.4px">
<li style="">Set <code style="font-family:Consolas,'Liberation
Mono',Menlo,Courier,monospace;font-size:11.9px;padding:0.2em
0px;margin:0px;border-radius:3px;background-color:rgba(0,0,0,0.0392157)">Expires</code> correctly</li>
<li style="">Support <code
style="font-family:Consolas,'Liberation
Mono',Menlo,Courier,monospace;font-size:11.9px;padding:0.2em
0px;margin:0px;border-radius:3px;background-color:rgba(0,0,0,0.0392157)">If-Modified-Since</code></li>
</ul>
<p
style="margin-top:0px;color:rgb(51,51,51);font-family:'Helvetica
Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple
Color Emoji','Segoe UI Emoji','Segoe UI
Symbol';font-size:14px;line-height:22.4px;margin-bottom:0px!important">This
pull request includes two private methods. These are
candidates to be moved into a central helper class, maybe as
static methods to be used anywhere in Yanel.</p>
<p
style="margin-top:0px;color:rgb(51,51,51);font-family:'Helvetica
Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple
Color Emoji','Segoe UI Emoji','Segoe UI
Symbol';font-size:14px;line-height:22.4px;margin-bottom:0px!important"><br>
</p>
<p
style="margin-top:0px;color:rgb(51,51,51);font-family:'Helvetica
Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple
Color Emoji','Segoe UI Emoji','Segoe UI
Symbol';font-size:14px;line-height:22.4px;margin-bottom:0px!important">Cheers,
Bas</p>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
</body>
</html>