<div dir="ltr">Hi Michael,<div><br></div><div>why didn't you take my pull request, modified it and then merged it with the master release? </div><div>From a contribution point of view it should be clear where the contributions came from and from which pull request.</div><div>Now that history is not visible in the yanel master branch.</div><div><br></div><div>Cheers, Balz</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 7, 2016 at 11:16 PM, Michael Wechner <span dir="ltr"><<a href="mailto:michael.wechner@wyona.com" target="_blank">michael.wechner@wyona.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div>Hi Balz<br>
<br>
I am currently reviewing<br>
<br>
<a href="https://github.com/wyona/yanel/pull/80" target="_blank">https://github.com/wyona/yanel/pull/80</a><br>
<br>
Can you close<br>
<br>
<a href="https://github.com/wyona/yanel/pull/75" target="_blank">https://github.com/wyona/yanel/pull/75</a><br>
<br>
?<br>
<br>
Thanks<br>
<br>
Michael<br>
<br>
Am 07.06.16 um 22:57 schrieb Michael Wechner:<br>
</div>
<blockquote type="cite">
<div>Hi Balz<br>
<br>
I have implemented "this", whereas I have made it configurable
for the redirect resource with version "1.0.2", e.g.<br>
<br>
<yanel:resource-config xmlns:yanel=<a href="http://www.wyona.org/yanel/rti/1.0" target="_blank">"http://www.wyona.org/yanel/rti/1.0"</a>><br>
<yanel:rti name="redirect" namespace=<a href="http://www.wyona.org/yanel/resource/1.0.2" target="_blank"></a><a href="http://www.wyona.org/yanel/resource/1.0.2" target="_blank">"http://www.wyona.org/yanel/resource/1.0.2"</a>/><br>
<br>
<yanel:property name="href" value="en/index.html"/><br>
<!-- INFO: We use 307 instead 301, such that the redirect
is always checked, in case the redirect location should change
in the future --><br>
<yanel:property name="status-code" value="307"/><br>
<br>
<br>
which means you can set it now to 301 or whatever.<br>
<br>
If you don't set it, then the default is still 307 for backwards
compatibility reasons, whereas I double checked that to be sure
that this makes sense.<br>
<br>
If you think the configurable version is not enough or that the
default should be 301, then please let me know, because we could
discuss to introduce a new redirect version, e.g. "redirect,
2.0.0" which uses 301.<br>
<br>
HTH<br>
<br>
Michael <br>
<br>
Am 03.06.16 um 12:58 schrieb basZero:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi,
<div><br>
</div>
<div>the easiest of the four pull requests I sent some time
ago is this one:</div>
<div><a href="https://github.com/wyona/yanel/pull/75" target="_blank">https://github.com/wyona/yanel/pull/75</a><br>
</div>
<div><br>
</div>
<div>It would be really great if these could be applied asap
before they become incompatible again (like those I sent
years ago).</div>
<div><br>
</div>
<div>Cheers, Balz</div>
</div>
<br>
<fieldset></fieldset>
<br>
</blockquote>
<br>
</blockquote>
<br>
</div>
<br>--<br>
Yanel-development mailing list <a href="mailto:Yanel-development@wyona.com">Yanel-development@wyona.com</a><br>
<a href="http://mx2.wyona.com/cgi-bin/mailman/listinfo/yanel-development" rel="noreferrer" target="_blank">http://mx2.wyona.com/cgi-bin/mailman/listinfo/yanel-development</a><br></blockquote></div><br></div>