<div dir="ltr">no I didn't close anything. I guess this was done automatically (because github knows that you fetched my pull request and merged it).<div><br></div><div>please note that you used "Balz" as your local branch name... so when you fetch my next pull request, I'd use a different name, maybe "balzpatch2" or something like that.</div><div>I will use patch1 to patchX for all upcoming patches to wyona repos.</div><div><br></div><div>Cheers</div><div>Balz</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 19, 2016 at 3:35 PM, Michael Wechner <span dir="ltr"><<a href="mailto:michael.wechner@wyona.com" target="_blank">michael.wechner@wyona.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div>that sounds great :-) thanks very
much!<br>
<br>
Btw, the process via pull request works very fine, whereas I have
pulled it as follows<br>
<br>
git fetch origin pull/5/head:Balz<br>
<br>
I am not sure how pull requests get closed. Did you just close it<br>
<br>
<a href="https://github.com/wyona/security/pulls" target="_blank">https://github.com/wyona/security/pulls</a><br>
<br>
?<br>
<br>
Thanks<br>
<br>
Michael<br>
<br>
Am 19.05.16 um 15:30 schrieb basZero:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Thanks Michael,
<div>no rush regarding integration into Yanel. I just wanted to
contribute und make sure they get in as quickly as possible.</div>
<div><br>
</div>
<div>I'll send more patches, I'm currently upgrading to the very
latest Yanel version.</div>
<div><br>
</div>
<div>Cheers</div>
<div><br>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Thu, May 19, 2016 at 3:23 PM,
Michael Wechner <span dir="ltr"><<a href="mailto:michael.wechner@wyona.com" target="_blank">michael.wechner@wyona.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div>Hi Balz<br>
<br>
I have reviewed, slightly changed and merged/pushed it<br>
<br>
<a href="https://github.com/wyona/security/commits/master/src/impl/java/org/wyona/security/impl/yarep/YarepUser.java" target="_blank">https://github.com/wyona/security/commits/master/src/impl/java/org/wyona/security/impl/yarep/YarepUser.java</a><br>
<br>
<a href="https://github.com/wyona/security/commit/173cf3f249c11d61f48f59f66e58b8d737549272#diff-5a495b4b80366327c00938fa50596480" target="_blank">https://github.com/wyona/security/commit/173cf3f249c11d61f48f59f66e58b8d737549272#diff-5a495b4b80366327c00938fa50596480</a><br>
<br>
I will now integrate this new version into Yanel. Will
write later again...<br>
<br>
Thanks<br>
<br>
Michael<br>
<br>
<br>
Am 19.05.16 um 11:19 schrieb basZero:<br>
</div>
<div>
<div>
<blockquote type="cite">
<div dir="ltr">Hi Michael,
<div><br>
</div>
<div>I create a super simple patch for
YarepUser.java:</div>
<div><a href="https://github.com/wyona/security/pull/5" target="_blank">https://github.com/wyona/security/pull/5</a><br>
</div>
<div><br>
</div>
<div>I hope you find time to apply it soon.</div>
<div><br>
</div>
<div>Cheers</div>
</div>
<br>
<fieldset></fieldset>
<br>
</blockquote>
<br><span class="HOEnZb"><font color="#888888">
</font></span></div><span class="HOEnZb"><font color="#888888">
</font></span></div><span class="HOEnZb"><font color="#888888">
</font></span></div><span class="HOEnZb"><font color="#888888">
<br>
--<br>
Yanel-development mailing list <a href="mailto:Yanel-development@wyona.com" target="_blank">Yanel-development@wyona.com</a><br>
<a href="http://mx2.wyona.com/cgi-bin/mailman/listinfo/yanel-development" rel="noreferrer" target="_blank">http://mx2.wyona.com/cgi-bin/mailman/listinfo/yanel-development</a><br>
</font></span></blockquote><span class="HOEnZb"><font color="#888888">
</font></span></div><span class="HOEnZb"><font color="#888888">
<br>
</font></span></div><span class="HOEnZb"><font color="#888888">
<br>
<fieldset></fieldset>
<br>
</font></span></blockquote>
<br>
</div>
<br>--<br>
Yanel-development mailing list <a href="mailto:Yanel-development@wyona.com">Yanel-development@wyona.com</a><br>
<a href="http://mx2.wyona.com/cgi-bin/mailman/listinfo/yanel-development" rel="noreferrer" target="_blank">http://mx2.wyona.com/cgi-bin/mailman/listinfo/yanel-development</a><br></blockquote></div><br></div>