[Yanel-dev] Patch: Make toolbar replaceable
Michael Wechner
michael.wechner at wyona.com
Fri Jan 21 20:08:29 CET 2011
Hi Simon
this has now been commited, but I noticed the following "problem":
Index: src/webapp/htdocs/yanel-js/superfish.js
===================================================================
--- src/webapp/htdocs/yanel-js/superfish.js (revision 56223)
+++ src/webapp/htdocs/yanel-js/superfish.js (working copy)
@@ -14,7 +14,7 @@
var sf = $yanelJquery144.fn.superfish,
c = sf.c,
- $yanelJquery144arrow = $yanelJquery144(['<span
class="',c.arrowClass,'"> »</span>'].join('')),
+ $yanelJquery144arrow = $yanelJquery144(['<span
class="',c.arrowClass,'"> </span>'].join('')),
over = function(){
var $yanelJquery144$yanelJquery144 =
$yanelJquery144(this), menu = getMenu($yanelJquery144$yanelJquery144);
clearTimeout(menu.sfTimer);
What exactly is this code snippet doing, because it seems to insert
"raquo"s at
<li class="haschild"><a href="foo">bar</a>...
whereas it seems like we can fix this by replacing 187 by 160 (as hinted
above).
WDYT?
Thanks
Michael
On 1/13/11 11:43 AM, simon wrote:
> Am 13.01.2011 11:31, schrieb Michael Wechner:
>> On 1/13/11 11:17 AM, simon wrote:
>>> Am 12.01.2011 10:22, schrieb Cedric Staub:
>>>> On Tue, Jan 11, 2011 at 06:11:11PM +0100, Simon wrote:
>>>>> Am 11.01.2011 16:57, schrieb Cedric Staub:
>>>>>> On Tue, Jan 11, 2011 at 04:25:28PM +0100, Simon wrote:
>>>>>>> i updated the patch. could be reviewed and applied ;)
>>>>>> Works fine here, except the timeout. When my mouse leaves the
>>>>>> menu, it
>>>>>> immediatly dissapears. I can see that the delay is set to 300ms
>>>>>> and I
>>>>>> even tried increasing it to 800ms, but it's still the same. Is the
>>>>>> timeout working for you? Otherwise it's pretty great :-)
>>>>> i'm glad you like it.
>>>>> on my site the delay works well. no idea what could be wrong.
>>>>> could you
>>>>> investigate a bit?
>>>> Nevermind, it works now (after I cleared my cache). I guess the next
>>>> step would be to split this out into a separate resource?
>>> i think next step is to commit this patch. and then change it to a
>>> resource.
>>
>> can you point me to this particular patch and I will be happy to
>> review it ;-)
>>
>> or is it this one
>>
>> http://bugzilla.wyona.com/cgi-bin/bugzilla/show_bug.cgi?id=8092
> yes it is this one.
>
> cheers
> simon
>>
>> ?
>>
>> Thanks
>>
>> Michael
>>>
>>> cheers
>>> simon
>>>> Cheers
>>>> Cedric
>>>
>>
>
More information about the Yanel-development
mailing list