[Yanel-dev] About cookies

[Cedric Staub]

On Thu, Sep 02, 2010 at 09:15:56AM +0100, Michael Wechner wrote:
> happy to accept patches ;-)

Here you go.
Cheers, Cedric
-------------- next part --------------
Index: src/webapp/src/java/org/wyona/yanel/servlet/AccessLog.java
===================================================================
--- src/webapp/src/java/org/wyona/yanel/servlet/AccessLog.java	(revision 52644)
+++ src/webapp/src/java/org/wyona/yanel/servlet/AccessLog.java	(working copy)
@@ -4,7 +4,7 @@
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 
-import java.util.Date;
+import java.util.UUID;
 import java.net.URLEncoder;
 import java.io.UnsupportedEncodingException;
 
@@ -112,7 +112,8 @@
         Cookie c = getYanelAnalyticsCookie(request);
         if (c != null) return c;
 
-        Cookie analyticsCookie = new Cookie(ANALYTICS_COOKIE_NAME, "YA-" + new Date().getTime()); // TODO: getTime() is not unique!
+        String value = "YA-" + UUID.randomUUID();
+        Cookie analyticsCookie = new Cookie(ANALYTICS_COOKIE_NAME, value);
         analyticsCookie.setMaxAge(31536000); // 1 year
         //analyticsCookie.setMaxAge(86400); // 1 day
         analyticsCookie.setPath(request.getContextPath());