[Yanel-dev] Toolbar implementation

[Michael Wechner]

Josias Thöny wrote:

> Michael Wechner wrote:
>
>> Hi
>>
>> I have implemented a prototype of the toolbar, whereas it's currently 
>> using an iframe, but this results in a long tail
>> of problems, so I think we rather use CSS and aggregate this on "top" 
>> of the actual content.
>
>
> Could you name the problems you encountered (just to have them kind of 
> documented)?


<base target="_top"/> needs to be added
Caching problems
Frame in frame problems
...

frames are just evil ;-)

>
>>
>> This has the drawback, that one cannot write directly into the 
>> response from within a resource, at least not for data with the 
>> mime-type "html" which shall be toolbar enabled. Technically speaking 
>> one checks on the method "View.isResponse()".
>>
>> Please let me know if you see other consequences.
>
>
> This would also mean that the toolbar cannot be displayed for binary 
> resources like e.g. images. Right?

no, but you are mentioning a good point.
But we could implement an "IF" and use iframes for images, etc.

WDYT?

Cheers

Michi

>
> Josias
>
>>
>> Thanks
>>
>> Michi
>>
>
>
> _______________________________________________
> Yanel-development mailing list
> Yanel-development at wyona.com
> http://wyona.com/cgi-bin/mailman/listinfo/yanel-development
>


-- 
Michael Wechner
Wyona      -   Open Source Content Management   -    Apache Lenya
http://www.wyona.com                      http://lenya.apache.org
michael.wechner at wyona.com                        michi at apache.org
+41 44 272 91 61